I program in C and python, and even good first issue problems seem like I have to be Dennis Ritchie himself to solve them. How do I know when I’m ready to solve and commit to projects?

  • heeplr@feddit.de
    link
    fedilink
    arrow-up
    7
    ·
    1 year ago

    Rather if they get merged without edits.

    I’ve seen even minor changes without flawed technique or style being discussed and changed for days before getting merged.

    But it’s also an excellent way to learn from pros. If the PR is worth it, they will spend the time for review and work with you until you fixed everything.

    • SokathHisEyesOpen@lemmy.ml
      link
      fedilink
      English
      arrow-up
      8
      ·
      1 year ago

      Eh, excellent code still gets discussed. Your approach might be unique and they haven’t thought of it before. Or you may have perfectly suitable code, but it doesn’t consider other parts of the project that you’re not familiar with. Discussion isn’t an indication of bad code, unless the only thing being discussed are mistakes.

      • macniel@feddit.de
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        That would be amazing, when your submission cause to improve the entire code base quality!